Carroll was initially brought to Leicester by Arthur Lochhead to try and help the club avoid relegation in 1935. His arrival came too late, however, but he did enjoy nearly three years with the club before moving to Luton Town and then Ayr United.

Carroll was a small and quick winger, his height helping him have a low centre of gravity that proved tricky for some defences to deal with it. His crosses were his trademark, and they were key in helping City to promotion in 1937. He chipped in with goals too, scoring 15 in the 1936-37 season.

He plied his trade in Scotland and Ireland, with clubs such as Strathclyde, Belfast Celtic and Shelbourne before arriving in Leicestershire. Off-the-field, Carroll was officially declared 'lost at sea' in 1944 as a result of enemy action but was rescued and made a welcome return to Filbert Street after the event. His job after football was a crane operator in Glasgow.